Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prosody: install prosody-migrator tool #102300

Merged
merged 1 commit into from Nov 1, 2020
Merged

prosody: install prosody-migrator tool #102300

merged 1 commit into from Nov 1, 2020

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Nov 1, 2020

Motivation for this change

It wasn't being installed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from picnoir, fpletz and globin November 1, 2020 01:09
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102300 run on x86_64-linux 1

1 package built:
  • prosody

picnoir
picnoir approved these changes Nov 1, 2020
View reviewed changes
Copy link
Member

@picnoir picnoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks!

@picnoir
Copy link
Member

picnoir commented Nov 1, 2020

I'd be interesting to know why upstream decided not to ship this via the main Makefile 🤔

@picnoir picnoir merged commit 5533013 into NixOS:master Nov 1, 2020
@arcnmx arcnmx deleted the prosody-migrator branch November 1, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnoir picnoir picnoir approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arcnmx @SuperSandro2000 @picnoir