Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

genpass: 0.4.1 -> 0.4.9 #102301

Merged
merged 1 commit into from Nov 2, 2020
Merged

genpass: 0.4.1 -> 0.4.9 #102301

merged 1 commit into from Nov 2, 2020

Conversation

cyplo
Copy link
Contributor

@cyplo cyplo commented Nov 1, 2020

  • caught up with the newest released version
  • genpass main repo moved to sourcehut
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cyplo
genpass: 0.4.1 -> 0.4.9
e687a4d 
* caught up with the newest released version
* genpass main repo moved to sourcehut
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102301 run on x86_64-darwin 1

1 package built:
  • genpass

stigtsp
stigtsp approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Built and tested OK on linux x64

New repo URL seems legit, it is referenced from:

Result of nixpkgs-review pr 102301 1

1 package built:
  • genpass

@stigtsp stigtsp merged commit 5df2fc2 into NixOS:master Nov 2, 2020
@cyplo
Copy link
Contributor Author

cyplo commented Nov 2, 2020

thank you !

@cyplo cyplo deleted the update-genpass branch November 2, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cyplo @SuperSandro2000 @stigtsp