Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mame: 0.225 -> 0.226 #102329

Merged
merged 1 commit into from Nov 1, 2020
Merged

mame: 0.225 -> 0.226 #102329

merged 1 commit into from Nov 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Nov 1, 2020 •
edited by ghost

cc @veprbl for testing on mac

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 1, 2020 •
edited

Result of nixpkgs-review pr 102329 run on x86_64-darwin 1

1 package failed to build:
  • mame
fontconfig -qt-freetype -qt-libpng -no-framework
/private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/toolchain.prf:3: Cannot find feature sdk
Info: creating stash file /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/.qmake.stash

This is the Qt Open Source Edition.

You have already accepted the terms of the Open Source license.

Running configuration tests...
Checking for valid makespec...
+ cd /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/config.tests/verifyspec && /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/bin/qmake "CONFIG -= qt debug_and_release app_bundle lib_bundle" "CONFIG += shared warn_off console single_arch" 'QMAKE_LIBDIR += /nix/store/x2r6z8m6h8aaq4g0sgkw8amfscdk1f6q-icu4c-67.1/lib /nix/store/bkbw8vp4g3fnkcsrw9ayfazk096rjd7n-zlib-1.2.11/lib /nix/store/4lcgzmjmipg8s4cg5qflhs5afnsaah19-libjpeg-turbo-2.0.5/lib /nix/store/xm0jvjxb2ga3vd5icpz0ldx57pjpzinp-harfbuzz-2.7.1/lib /nix/store/4115fabrf3hcccwa760057pqxvssmh13-openssl-1.1.1g/lib' 'INCLUDEPATH += /nix/store/dmy9q4cm6c9nzdar7nqgn06gvkgxsid1-icu4c-67.1-dev/include /nix/store/7dw65jc4r4vkaqizzcx1njyryi8vw7vm-zlib-1.2.11-dev/include /nix/store/fhmc6vlgh1vcjilhs4z5fjlfr6qbbqmq-libjpeg-turbo-2.0.5-dev/include /nix/store/yr68z4q8i7bzk6z93q58vvzqwyvyy33i-harfbuzz-2.7.1-dev/include /nix/store/bid8wmf6fb5kg702ywnl7zjzh5158dnr-openssl-1.1.1g-dev/include' /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/config.tests/verifyspec
> /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/toolchain.prf:3: Cannot find feature sdk
> Info: creating stash file /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/config.tests/.qmake.stash
> /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/default_post.prf:5: 'xcodeSDKInfo' is not a recognized replace function.
> Project WARNING: Qt requires at least version 10.14 of the platform SDK, you're building against version . Please upgrade.
+ cd /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/config.tests/verifyspec && MAKEFLAGS= /nix/store/c3v8mz19las3k4afgqfjj9h054yv9sbz-gnumake-4.3/bin/make
> Makefile:69: /private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/sdk.mk: No such file or directory
> make: *** No rule to make target '/private/tmp/nix-build-qtbase-5.14.2.drv-0/qtbase-everywhere-src-5.14.2/mkspecs/features/mac/sdk.mk'.  Stop.
Note: Option 'verbose' with value 'true' was specified twice

Note: -docdir is not a subdirectory of -prefix.
Note: -plugindir is not a subdirectory of -prefix.
Note: -qmldir is not a subdirectory of -prefix.

ERROR: Cannot compile a minimal program. The toolchain or QMakeSpec is broken.
builder for '/nix/store/4v66czqj5sv19i335rpnykkj96ww3zwa-qtbase-5.14.2.drv' failed with exit code 3
cannot build derivation '/nix/store/5qc3zid03jn5hmrsrvaj6wx3rv92xhs7-mame-0.225.drv': 1 dependencies couldn't be built
error: build of '/nix/store/5qc3zid03jn5hmrsrvaj6wx3rv92xhs7-mame-0.225.drv' failed

veprbl
veprbl approved these changes Nov 1, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veprbl veprbl merged commit eae2982 into NixOS:master Nov 1, 2020
@ghost
Copy link
Author

ghost commented Nov 1, 2020

@veprbl @SuperSandro2000 Thanks!

@ghost ghost deleted the mame branch November 1, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @veprbl