Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyobjc: Reinit #102306

Closed
wants to merge 171 commits into from
Closed

python3Packages.pyobjc: Reinit #102306

wants to merge 171 commits into from

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 1, 2020 •
edited

ToDo
  • Verify update script
  • Re-run update script and check for missing modules
  • reflow imports
  • force push all of the above
  • nixpkgs-review rebuilds everything so not really possible
Python packages to unbreak after this is merged:
Motivation for this change

#21829
Closes #101360

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 changed the title Rework pyobjc python3Packages.pyobjc: Reinit Nov 1, 2020
@Mic92
Copy link
Member

Mic92 commented Nov 1, 2020 •
edited

Maybe also @dasJ for partial nix review (nix-review -p <attrname>)

@Mic92
Copy link
Member

Mic92 commented Nov 1, 2020

How are these packages going to be maintained?

They are largely auto-generated as you can see from the script at the end.

@FRidh
Copy link
Member

FRidh commented Nov 1, 2020

How are these packages going to be maintained?

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Nov 1, 2020 •
edited

How are these packages going to be maintained?

The update script should have a version in the top fetches the latest version from pypi and if a new version is released you change that, build everything and fix any problems or add new modules.

@Mic92
Copy link
Member

Mic92 commented Nov 1, 2020

I cherry-picked the mass-rebuilding change here: #102348

@dasJ
Copy link
Member

dasJ commented Nov 1, 2020

@Mic92 feel free to ping me again when Hydra did all the mass-rebuild stuff

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Nov 1, 2020 •
edited

Is it rebuilding everything darwin because of the changes in pkgs/os-specific/darwin/apple-sdk/frameworks.nix ?

@dasJ
Copy link
Member

dasJ commented Nov 2, 2020

Progress on Darwin so far: [21/27872 built (5 failed), 1/15439/24483 copied (30937.3/100120.9 MiB), 15716.3/38630.9 MiB DL]

@dasJ
Copy link
Member

dasJ commented Nov 2, 2020

The last failed build I see is:

  ld: warning: passed two min versions (10.12.0, 10.12) for platform macOS. Using 10.12.
  ld: library not found for -lunistring
  clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
  make[2]: *** [Makefile:624: doboot.shared] Error 1
  make[2]: Leaving directory '/private/tmp/nix-build-bigloo-4.3h.drv-0/bigloo-4.3h/comptime'
  make[1]: *** [Makefile:616: boot] Error 2
  make[1]: Leaving directory '/private/tmp/nix-build-bigloo-4.3h.drv-0/bigloo-4.3h/comptime'
  make: *** [Makefile:169: boot-c] Error 2
builder for '/nix/store/ji10s1mk80ldcd7mc0ia8dbyba12p604-perl5.30.3-Mac-Pasteboard-0.009.drv' failed with exit code 2; last 10 log lines:

  Test Summary Report
  -------------------
  t/basic.t     (Wstat: 256 Tests: 11 Failed: 1)
    Failed test:  11
    Non-zero exit status: 1
  Files=2, Tests=16,  1 wallclock secs ( 0.01 usr  0.01 sys +  0.12 cusr  0.20 csys =  0.34 CPU)
  Result: FAIL
  Failed 1/2 test programs. 1/16 subtests failed.
  make: *** [Makefile:1100: test_dynamic] Error 255
builder for '/nix/store/v558afp5759wh9ixz6bfy3nkn2mcdgr5-perl5.32.0-Mac-Pasteboard-0.009.drv' failed with exit code 2; last 10 log lines:

  Test Summary Report
  -------------------
  t/basic.t     (Wstat: 256 Tests: 11 Failed: 1)
    Failed test:  11
    Non-zero exit status: 1
  Files=2, Tests=16,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.12 cusr  0.19 csys =  0.33 CPU)
  Result: FAIL
  Failed 1/2 test programs. 1/16 subtests failed.
  make: *** [Makefile:1101: test_dynamic] Error 255
cannot build derivation '/nix/store/4fnnc67hv23j9q42gai7b2vrfq25bwr7-kpcli-3.4.drv': 1 dependencies couldn't be built

@SuperSandro2000
python3Packages.pyobjc-framework-CryptoTokenKit: Switch to import check
591e4ed 
due to running 0 tests
@SuperSandro2000
python3Packages.pyobjc-framework-LaunchServices: Switch to import check
e3d6e1d 
due to running 0 tests
@SuperSandro2000
python3Packages.pyobjc: Fix objc4 detection
78631ba
@SuperSandro2000
python3Packages.pyobjc: 6.2 -> 6.2.2, cleanup packages that work with
1f26ebb 
the current sdk version
@SuperSandro2000
python3Packages.pyobjc: Allow specificing version in update script, fix
88d9774 
typos, cleanups
@SuperSandro2000
apple_sdk.frameworks: Add CloudKit
9f1a2d7
@SuperSandro2000
apple_sdk.frameworks: Add FinderSync
4549dc9
@SuperSandro2000
apple_sdk.frameworks: Add MediaLibrary
8ebc357
@SuperSandro2000
apple_sdk.frameworks.QTKit: Fix error when python enviroment is created
53b3aad 
and /System/Library/Frameworks/QuickTime.framework does not exist
@SuperSandro2000
python3Packages.pyobkc-frameworks-*: Fix issues when sandbox is enabled
852c2c6
@SuperSandro2000
Copy link
Member Author

In the last force push I removed all apple framweworks which get added in the future sdk versions, pyobjc is no longer build with future packages and pyobjc can be build with sandboxing on.

@SuperSandro2000
Copy link
Member Author

@ofborg build python3Packages.pyobjc

@SuperSandro2000 SuperSandro2000 mentioned this pull request Apr 8, 2021
Closed
10 tasks
@SuperSandro2000 SuperSandro2000 added this to the 21.05 milestone Apr 8, 2021
@lukegb lukegb mentioned this pull request Apr 9, 2021
Closed
10 tasks
@stale
Copy link

stale bot commented Oct 12, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 12, 2021
@abathur abathur mentioned this pull request Feb 6, 2022
Open
@KamilaBorowska KamilaBorowska mentioned this pull request May 9, 2022
Merged
13 tasks
@Artturin Artturin modified the milestones: 21.05, 23.05 Dec 31, 2022
@stale stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Dec 31, 2022
Staging automation moved this from Needs review to Done Feb 6, 2023
@SuperSandro2000 SuperSandro2000 deleted the rework-pyobjc branch February 6, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt left review comments

@veprbl veprbl veprbl left review comments

@FRidh FRidh FRidh left review comments

@thefloweringash thefloweringash thefloweringash requested changes

@Mic92 Mic92 Mic92 requested changes

@jonringer jonringer Awaiting requested review from jonringer

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 1-10
Projects
Staging
  
Done
Milestone
23.05
Development

Successfully merging this pull request may close these issues.

Enabling pyobjc on python3Packages
10 participants
@SuperSandro2000 @Mic92 @FRidh @dasJ @veprbl @jonringer @siraben @thefloweringash @mweinelt @Artturin