Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vuescan: 9.7.35 -> 9.7.37 #102343

Closed
wants to merge 1 commit into from
Closed

vuescan: 9.7.35 -> 9.7.37 #102343

wants to merge 1 commit into from

Conversation

evax
Copy link
Contributor

@evax evax commented Nov 1, 2020

Motivation for this change

Update to latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evax
Copy link
Contributor Author

evax commented Nov 1, 2020

The minor versions are released in place, using the same file name, so this will break on every new minor release. Is there a standard way to deal with this in nixpkgs? Could we cache the binaries somewhere?

@evax
Copy link
Contributor Author

evax commented Nov 9, 2020

9.7.37 is already out and this wasn't merged. I'll update this PR shortly. I'd appreciate some feedback on the caching point I'm making above.

@evax evax changed the title vuescan: 9.7.35 -> 9.7.36 vuescan: 9.7.35 -> 9.7.37 Nov 9, 2020
@evax
Copy link
Contributor Author

evax commented Nov 10, 2020

@garbas, sorry to bother you, you merged the initial package in, the package in master is broken and uninstallable until this is merged. I would also greatly appreciate any feedback you might have on the caching point I'm bringing up above.

@garbas
Copy link
Member

garbas commented Nov 17, 2020

@evax The sha's are out of sync again. The url provided is for 9.7.x and they change those files. I would recommend contacting the upstream if they can provide permanent links for their releases.

@evax
Copy link
Contributor Author

evax commented Nov 17, 2020

Hi @garbas, thanks for your feedback. I contacted the author and he's stating he explicitly forbids packaging of his software. I'm closing this pull request and will open a new one to remove the package.

@evax evax closed this Nov 17, 2020
@evax evax mentioned this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants