Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adoptopenjdk: update to latest & add 14 & 15 #102315

Merged
merged 1 commit into from Nov 23, 2020
Merged

adoptopenjdk: update to latest & add 14 & 15 #102315

merged 1 commit into from Nov 23, 2020

Conversation

andreoss
Copy link
Contributor

@andreoss andreoss commented Nov 1, 2020

should fix #98784

@andreoss andreoss changed the title adoptjdk: update to latest & add 14 & 15 adoptopenjdk: update to latest & add 14 & 15 Nov 1, 2020
@SuperSandro2000
Copy link
Member

Can you please follow the commit style described in the contribution guide?

@andreoss andreoss force-pushed the master branch 2 times, most recently from 40042f2 to a1f8ceb Compare November 1, 2020 04:27
@andreoss
Copy link
Contributor Author

andreoss commented Nov 1, 2020

@SuperSandro2000 Done.

@SuperSandro2000
Copy link
Member

The commit style is package: change without your ().

@andreoss
Copy link
Contributor Author

andreoss commented Nov 1, 2020

@SuperSandro2000 Sorry, misread the requirements. Now it should be fine.

@gytis-ivaskevicius
Copy link
Contributor

@SuperSandro2000 ping

@taku0
Copy link
Contributor

taku0 commented Nov 22, 2020 •
edited

adoptopenjdk: 8.0.252 -> 8.0.272, 11.0.7 -> 11.0.9, add 14.0.2, add 15.0.1 would be helpful for later git log.

@andreoss
Copy link
Contributor Author

@taku0 Fixed commit message.

@taku0
Copy link
Contributor

taku0 commented Nov 23, 2020

Please add stdenv.cc.cc.lib to buildInputs to build 14 and 15.

@ofborg ofborg bot requested a review from taku0 November 23, 2020 09:08
@taku0
Copy link
Contributor

taku0 commented Nov 23, 2020

This requires mass-rebuilds, so please rebase on staging branch instead of master.

@andreoss andreoss changed the base branch from master to staging November 23, 2020 09:20
@ofborg ofborg bot requested a review from taku0 November 23, 2020 09:30
@taku0 taku0 merged commit ab0d840 into NixOS:staging Nov 23, 2020
@taku0
Copy link
Contributor

taku0 commented Nov 23, 2020

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taku0 taku0 taku0 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: OpenJDK 15
5 participants
@andreoss @SuperSandro2000 @gytis-ivaskevicius @taku0 @Janik-Haag