Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vkquake: 1.04.1 -> 1.05.0 #102331

Merged
merged 1 commit into from Nov 1, 2020
Merged

vkquake: 1.04.1 -> 1.05.0 #102331

merged 1 commit into from Nov 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 1, 2020

Motivation for this change

Removed patch. cc @peterhoeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh requested a review from peterhoeg November 1, 2020 11:51
@peterhoeg peterhoeg merged commit 8c7ef10 into NixOS:master Nov 1, 2020
@ghost
Copy link
Author

ghost commented Nov 1, 2020

@peterhoeg @FRidh Thanks!

@ghost ghost deleted the vkquake branch November 1, 2020 12:59
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102331 run on x86_64-linux 1

1 package failed to build:
  • vkquake

@ghost
Copy link
Author

ghost commented Nov 1, 2020

Result of nixpkgs-review pr 102331 1

1 package built:
  • vkquake

@SuperSandro2000
Copy link
Member

Not sure why my build failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @peterhoeg