Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: e3d3bc66dc49
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 5dc3838d0571
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Oct 27, 2020

  1. ruby: make the build reproducible 

    ext/io/console/io-console.gemspec was embedding a timestamp which made
the build not reproducible. Gems respect SOURCE_DATE_EPOCH so it's
enough to just delete that line if it exists.

This file has been fixed in
ruby/io-console@679a941#diff-d8422f096931c58d4463e2489f62a228b0f24f0492950ba88c8c89a0d741cfe6
And then ruby regularly merges that gem into their own repository. Ruby
master is fixed but none of the ruby releases have been fixed yet.

lib/ruby/gems/2.6.0/specifications/default/io-console-0.4.7.gemspec now
contains:

    s.date = "1980-01-01"
    @zimbatm
    zimbatm committed Oct 27, 2020
    Copy the full SHA
    7aee321 View commit details
    Browse the repository at this point in the history

  2. buildRubyGem: remove Makefiles 

    The generated Makefile is not reproducible. The HDRS section is inode
dependent. "sitearchdir" and "sitelibdir" contains a timestamp and
random postfix. See https://r13y.com/diff/8350ec80865096f84705f3e000d97f151760e768bf626e52c84570413c5e1093-f9dea788fe62d683e90e12e166f29b778c39c699a5be39f9262e5cffb77d3e45.html

Instead of trying to make it reproducible, remove it entirely. It was
only useful for generating the .so file and it no longer needed.

See also https://bugs.ruby-lang.org/issues/15304

Fixes the rubyPackages.nokogiry reproducibility for example.
    @zimbatm
    zimbatm committed Oct 27, 2020
    Copy the full SHA
    c3357d2 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #101655 from zimbatm/ruby-r13y 

    ruby: make the build reproducible
    @zimbatm
    zimbatm committed Oct 27, 2020
    Copy the full SHA
    5dc3838 View commit details
    Browse the repository at this point in the history