Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonnet-bundler: init at 0.4.0 #101865

Merged
merged 2 commits into from Nov 26, 2020
Merged

jsonnet-bundler: init at 0.4.0 #101865

merged 2 commits into from Nov 26, 2020

Conversation

Preisschild
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Oct 27, 2020
View reviewed changes
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/development/tools/jsonnet-bundler/default.nix Outdated Show resolved Hide resolved
@Preisschild Preisschild marked this pull request as draft October 27, 2020 18:59
@Preisschild Preisschild marked this pull request as ready for review October 27, 2020 19:03
@ofborg ofborg bot requested a review from kalbasit October 27, 2020 19:11
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 27, 2020 •
edited

Run on darwin:

Result of nixpkgs-review pr 101865 1

1 package failed to build:
  • jsonnet-bundler

@Preisschild
Copy link
Contributor Author

Run on darwin:

Result of nixpkgs-review pr 101865 1
1 package failed to build:

Thanks for the information, I'll check tomorrow if i can reproduce on darwin.

@Preisschild Preisschild marked this pull request as draft October 27, 2020 19:23
@Preisschild Preisschild force-pushed the jsonnet-bundler/init branch 5 times, most recently from 03d2e64 to e9bfc07 Compare October 27, 2020 20:12
@Preisschild Preisschild marked this pull request as ready for review October 27, 2020 20:20
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 28, 2020 •
edited

This got fixed cause ruby got fixed on darwin 3 days ago. Didn't remember that this was the case.

Run on darwin:

Result of nixpkgs-review pr 101865 1

1 package built:
  • jsonnet-bundler

@Preisschild
Copy link
Contributor Author

Nice, just tested it on darwin too, all tests are OK and the program works.

@Preisschild Preisschild marked this pull request as draft October 28, 2020 17:29
@Preisschild Preisschild marked this pull request as ready for review October 28, 2020 17:32
@Preisschild
Copy link
Contributor Author

sorry for adding some people as reviewer, i had a bad rebase

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101865 run on x86_64-linux 1

1 package built:
  • jsonnet-bundler

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101865 run on x86_64-darwin 1

1 package built:
  • jsonnet-bundler

@SuperSandro2000 SuperSandro2000 merged commit e0c7219 into NixOS:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@sikmir sikmir sikmir approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Preisschild @SuperSandro2000 @sikmir