Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate autocompletion database for awscli2 #101861

Closed
wants to merge 1 commit into from
Closed

Generate autocompletion database for awscli2 #101861

wants to merge 1 commit into from

Conversation

jdelStrother
Copy link
Contributor

Motivation for this change

Installing awscli2 and trying to use tab-completion fails and prints an error:

  File "/nix/store/dyvz5p30dl0jv2g6wlb7i0l0pnsa9hpy-awscli2-2.0.54/bin/.aws_completer-wrapped", line 37, in <module>
    main()
  File "/nix/store/dyvz5p30dl0jv2g6wlb7i0l0pnsa9hpy-awscli2-2.0.54/bin/.aws_completer-wrapped", line 29, in main
    autocomplete(command_line, command_index)
  File "/nix/store/dyvz5p30dl0jv2g6wlb7i0l0pnsa9hpy-awscli2-2.0.54/lib/python3.8/site-packages/awscli/autocomplete/main.py", line 61, in autocomplete
    results = completer.autocomplete(command_line, position)
  File "/nix/store/dyvz5p30dl0jv2g6wlb7i0l0pnsa9hpy-awscli2-2.0.54/lib/python3.8/site-packages/awscli/autocomplete/completer.py", line 42, in autocomplete
    parsed = self._parser.parse(command_line, index)
  File "/nix/store/dyvz5p30dl0jv2g6wlb7i0l0pnsa9hpy-awscli2-2.0.54/lib/python3.8/site-packages/awscli/autocomplete/parser.py", line 145, in parse
    global_args = self._index.arg_names(lineage=[], command_name='aws')
  File "/nix/store/dyvz5p30dl0jv2g6wlb7i0l0pnsa9hpy-awscli2-2.0.54/lib/python3.8/site-packages/awscli/autocomplete/local/model.py", line 104, in arg_names
    results = db.execute(self._ARG_NAME_QUERY,
  File "/nix/store/dyvz5p30dl0jv2g6wlb7i0l0pnsa9hpy-awscli2-2.0.54/lib/python3.8/site-packages/awscli/autocomplete/db.py", line 33, in execute
    return self._connection.execute(query, kwargs)
  File "/nix/store/dyvz5p30dl0jv2g6wlb7i0l0pnsa9hpy-awscli2-2.0.54/lib/python3.8/site-packages/awscli/autocomplete/db.py", line 23, in _connection
    self._db_conn = sqlite3.connect(
sqlite3.OperationalError: unable to open database file

As far as I can tell, awscli's official packages come pre-populated with their completion database (awscli/data/ac.index) pre-populated. In this PR, I've run it in postBuild.
You can test the results from the build-directory with env COMP_LINE='aws athena get' result/bin/aws_completer

I'm not a python developer / nix developer / aws developer, so it's entirely possible I've missed something silly, let me know if so.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes I thought to make.
Also, you commit message doesn't match contribution guidelines

awscli2: generate autocompletion database

https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

pkgs/tools/admin/awscli2/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/awscli2/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/awscli2/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from bhipple October 27, 2020 16:33
dbirks
dbirks suggested changes Nov 11, 2020
View reviewed changes
Copy link
Member

@dbirks dbirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this. Having working autocomplete is so nice to have. Here's some changes I've made while testing with nixpkgs-review:

pkgs/tools/admin/awscli2/default.nix Outdated Show resolved Hide resolved
@teto
Copy link
Member

teto commented Mar 18, 2021

@jdelStrother is this ready ?

@jdelStrother
Copy link
Contributor Author

Yes... though it looks like it's been fixed separately in #103718 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@dbirks dbirks dbirks approved these changes

@bhipple bhipple Awaiting requested review from bhipple

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jdelStrother @teto @dbirks @worldofpeace