Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 44c4060f38d7
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 190b3dada61f
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 28, 2020

  1. steam: Do $PATH lookup in steam.desktop instead of hardcoding derivation 

    The desktop application and the absoloute path work fine.
But consider desktop environments such as KDE where, in the application
menu, one can right click entries and pin them to widgets/panels, add
them to the desktop, etc.

Doing so effectively means copying
/run/current-system/sw/share/applications/steam.desktop to
~/.local/share/plasma_icons/ or ~/Desktop/, i.e. managed stated gets
duplicated outside the nix scope.

The problem here is that steam.desktop hardcodes

	Exec=/nix/store/<derivation hash>-steam/bin/steam %U

this means such copies will point at wrong/outdated derivations once
the steam package changes, i.e. widgets/panels/desktop icons will no
longer work and must be recreated.

Therefore replace the absoloute path with a $PATH lookup to allow "safe"
copying;  this isn't optimal but other applications such Firefox and
Thunderbrid currently behave the same way ($PATH lookup in their
.desktop file).

(cherry picked from commit db236e5)
    @klemensn @andir
    klemensn authored and andir committed Oct 28, 2020
    Copy the full SHA
    190b3da View commit details
    Browse the repository at this point in the history