Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib.fifo.AsyncFFSynchronizer: check input and output signal width #517

Merged
merged 1 commit into from Oct 28, 2020
Merged

lib.fifo.AsyncFFSynchronizer: check input and output signal width #517

merged 1 commit into from Oct 28, 2020

Conversation

rroohhh
Copy link
Contributor

@rroohhh rroohhh commented Oct 27, 2020

wasted more time than I would like to admit due to this :)

@codecov
Copy link

codecov bot commented Oct 27, 2020 •
edited

Codecov Report

Merging #517 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
+ Coverage   81.37%   81.38%   +0.01%     
==========================================
  Files          49       49              
  Lines        6410     6414       +4     
  Branches     1280     1282       +2     
==========================================
+ Hits         5216     5220       +4     
- Misses       1005     1006       +1     
+ Partials      189      188       -1
Impacted Files Coverage Δ
nmigen/lib/cdc.py 90.69% <100.00%> (+0.45%) ⬆️
nmigen/build/run.py 22.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 765c15c...de1e825. Read the comment docs.

whitequark
whitequark requested changes Oct 27, 2020
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits:

  • By convention, all error checking happens at the function entry.
  • The error messages would be easier to read and more consistent with our other error messages if they used 1, not one.

@rroohhh
Copy link
Contributor Author

rroohhh commented Oct 27, 2020

async_edge is also not checked at the function entry, should that be changed aswell?

@whitequark
Copy link
Member

Yup.

@whitequark whitequark merged commit 05decc4 into amaranth-lang:master Oct 28, 2020
@whitequark
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rroohhh @whitequark