Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cleanUrl and fragment hack #216

Merged
merged 7 commits into from Oct 28, 2020
Merged

Remove cleanUrl and fragment hack #216

merged 7 commits into from Oct 28, 2020

Conversation

turboMaCk
Copy link
Member

I just removed the cleanUrl function and updated all the places I found where #disabled fragment was used. I think this is enough to remove the hack. I tested the behavior there are no refreshes going on.

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f9889b6a9211312cdccb95b--nixos-search.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f988cbeb8755e19295b83de--nixos-search.netlify.app

@garbas
Copy link
Member

garbas commented Oct 27, 2020

The hack is not completely removed. In src/Main.elm

Also removing the #disabled from the url now triggers the request to the backend when those links are clicked, which is not the case on master (you can compare it with search.nixos.org).

@garbas garbas self-requested a review October 27, 2020 21:26
@garbas garbas added the enhancement New feature or request label Oct 27, 2020
@turboMaCk turboMaCk marked this pull request as draft October 28, 2020 21:00
@turboMaCk turboMaCk force-pushed the turboMaCk/avoid-fragment-hack branch from f7fc7b0 to d9b790e Compare October 28, 2020 21:04
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f99dd59bc87164810f6070a--nixos-search.netlify.app

turboMaCk
turboMaCk commented Oct 28, 2020
View reviewed changes
src/Main.elm Show resolved Hide resolved
turboMaCk
turboMaCk commented Oct 28, 2020
View reviewed changes
src/Main.elm Show resolved Hide resolved
@turboMaCk turboMaCk marked this pull request as ready for review October 28, 2020 23:09
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f99fadf66dfb826c07ca3bc--nixos-search.netlify.app

garbas
garbas approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@garbas garbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have some naming comments but other then that it looks and works perfectly.

src/Main.elm Outdated Show resolved Hide resolved
src/Main.elm Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f99ff64793148275b141b03--nixos-search.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f9a007cefcb9822b0c42ea8--nixos-search.netlify.app

@garbas garbas merged commit 2de4ef3 into master Oct 28, 2020
@garbas garbas deleted the turboMaCk/avoid-fragment-hack branch October 28, 2020 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbas garbas garbas approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turboMaCk @garbas