Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.pyosmium: 2.15.3 -> 3.0.1 #101882

Merged
merged 1 commit into from Nov 7, 2020
Merged

python3.pkgs.pyosmium: 2.15.3 -> 3.0.1 #101882

merged 1 commit into from Nov 7, 2020

Conversation

das-g
Copy link
Member

@das-g das-g commented Oct 27, 2020 •
edited

Motivation for this change

upstream releases:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix run nixpkgs.nixpkgs-review -c nixpkgs-review pr 101882 --post-result
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@das-g
Copy link
Member Author

das-g commented Oct 27, 2020

Result of nixpkgs-review pr 101882 1

2 packages built:
  • python37Packages.pyosmium
  • python38Packages.pyosmium

@ofborg ofborg bot requested a review from sikmir October 27, 2020 22:28
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 27, 2020 •
edited

Run on darwin:

Result of nixpkgs-review pr 101882 1

2 packages built:
  • python37Packages.pyosmium
  • python38Packages.pyosmium

@jonringer
Copy link
Contributor

do we need 3 bump commits?

Personally, I think it should be squashed to one.

@das-g
Copy link
Member Author

das-g commented Oct 28, 2020

do we need 3 bump commits?

We don't need them, but I thought it easier to review when one can see what changes are related to what release.

Personally, I think it should be squashed to one.

Squashed to 11f9033 now.

@ofborg ofborg bot requested a review from sikmir October 28, 2020 18:45
@marsam marsam merged commit e732be9 into NixOS:master Nov 7, 2020
@das-g das-g deleted the pyosmium branch February 8, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@das-g @SuperSandro2000 @jonringer @sikmir @marsam