New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solc: 0.6.8 -> 0.7.4 #101873
solc: 0.6.8 -> 0.7.4 #101873
Conversation
Run on darwin: Result of 3 packages failed to build:
|
I don't have Darwin and can't test. It's possible that some change in the latest solc release breaks on clang. Can you give more context for the error? |
In any case, this seems to be an improvement over 0.6.8 that doesn't currently build. |
Here is the complete log. I think this is an upstream issue:
|
Does it work if you use |
Meanwhile, I'll see if using |
Using
|
On the other hand, using
|
Use gccStdenv to avoid issues with clang on Darwin.
I pushed a new version that unconditionally uses |
Result of 3 packages failed to build:
solc
|
Weird: It worked for me on NixOS Linux x86-64 !?!? Is it a fluke or is it reproducible? |
It also worked for ofborg. |
|
I don't understand. Why is it working for me & ofborg and not for you??? What's different about our setups? |
At least, your failure is consistent. |
Now solc builds but something depending on it not.
Fixed in #102966 |
Supersedes #97730 |
I tried to update slither-analyzer from 0.6.12 to 0.6.13 in case that helped, but building fails with:
I'm not familiar with how Nix wraps over pip, and I don't see crytic anywhere in nixpkgs so I suppose it's coming directly from the pip configuration of slither-analyzer, which doesn't make me optimistic about fixing it without digging into the upstream code. |
Note that when I try to build the unmodified slither-analyzer 0.6.12, I get a similar error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 101873 1
3 packages built:
- python37Packages.slither-analyzer
- slither-analyzer (python38Packages.slither-analyzer)
- solc
Motivation for this change
Current package 0.6.8 doesn't build anymore, so updating it.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)