New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix asciinema player breaking site width #634
Conversation
(Edited the issue post as it does not fix the issue.) |
There is also a problem with the padding here. This is not the solution. I have to look a bit more into it. |
This reverts commit cecf6cb.
The reason there was that aspect ratio thing there was to, if I remember right, make the whole player fit in the height of a side-ways mobile device. Though I think I must have forgotten to finish implementing this, as instead it just resolved to using the default font sizes. Rather, let's do what works fine for every other sizes: a ratio of the device width.
I have reverted your changes, and applied a change that can be tested and checked. Though, I would suggest we rebase and drop the now useless first two commits (outide of the GitHub UI!). I simply didn't do it because rebasing on a shared branch is rude :). |
@samueldr feel free to rebase next time :) I'm going to open a new PR with your commit. |
#637 is where this PR continues |
Oops, forgot that I added a "closes" to the other PR lol. And noted for rebasing work. |
Fixes #597
@samueldr I wonder if we should move this fix to
#flex-flexible-spacing
to apply it across all the site?This change is