New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
groff: fix PDF manpage building with -Tpdf/gropdf #101866
Conversation
These files are pure data, just fonts; they shouldn't have been moved to the "perl" output, because the Perl programs (namely, gropdf) use them from the main "out" output. These files don't contain any references to more dependencies (Perl or otherwise), so they don't bloat the closure. And the files themselves are small; 276K total as of this commit.
I've had this issue; I've tried to build groff with this patch locally to fix it, but it seems like there's no www.tmac in the tarball? ( |
@cirno-999 That's the build error you get from running nix-build? Did you make some other local change? Maybe you updated to a new version? It builds fine for me, and this has been in master for a week now so it seems to build fine for everyone. |
You could say I made a local change, I defined my own package from the source |
I'm guessing, from the error message, that you're building directly from groff's git repo and not a groff release tarball. That won't work in general; tarballs are not necessarily the same as what's in git. (For example, you might need to run autoreconf -i to generate some additional files when building from git; there's autoreconfHook in Nixpkgs which automates this if you add it to buildInputs.) Anyway, that seems unrelated to this issue. |
no, I'm building from tarball (but feel free to not continue this discussion if you feel it's not relevant.) |
Can you paste the change you made? (Mainly for the URL to the tarball) |
my configuration is at https://github.com/cirno-999/berlin |
That appears to be a complete copy and paste of the package. I was more hoping for a diff. You might try using overrideAttrs instead to change just the "src" attribute: https://nixos.org/manual/nixpkgs/stable/#sec-pkg-overrideAttrs |
These files are pure data, just fonts; they shouldn't have been moved
to the "perl" output, because the Perl programs (namely, gropdf) use
them from the main "out" output.
These files don't contain any references to more dependencies (Perl or
otherwise), so they don't bloat the closure. And the files themselves
are small; 276K total as of this commit.