Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.google_cloud_asset: fix build, 2.0.0 -> 2.1.0 #100546

Merged
merged 4 commits into from Oct 15, 2020
Merged

[20.09] python3Packages.google_cloud_asset: fix build, 2.0.0 -> 2.1.0 #100546

merged 4 commits into from Oct 15, 2020

Conversation

austinbutler
Copy link
Member

Motivation for this change

Backport of: #100009

ZHF: #97479
https://hydra.nixos.org/build/127625743

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from costrouc and ruuda October 15, 2020 05:07
jonringer
jonringer approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 100546 1

10 packages built:
  • python37Packages.google-cloud-access-context-manager
  • python37Packages.google-cloud-org-policy
  • python37Packages.google_cloud_asset
  • python37Packages.google_cloud_dataproc
  • python37Packages.libcst
  • python38Packages.google-cloud-access-context-manager
  • python38Packages.google-cloud-org-policy
  • python38Packages.google_cloud_asset
  • python38Packages.google_cloud_dataproc
  • python38Packages.libcst

@jonringer jonringer merged commit 2450fe8 into NixOS:release-20.09 Oct 15, 2020
@austinbutler austinbutler deleted the google_cloud_asset-backport branch October 16, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@costrouc costrouc Awaiting requested review from costrouc

@ruuda ruuda Awaiting requested review from ruuda

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@austinbutler @jonringer