Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.libsass: init at 0.20.1 #100521

Merged
merged 1 commit into from Nov 26, 2020
Merged

pythonPackages.libsass: init at 0.20.1 #100521

merged 1 commit into from Nov 26, 2020

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 14, 2020 •
edited

Motivation for this change

Required for another python package I wanted to use.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 force-pushed the python-libsass branch 3 times, most recently from c48b2ef to af8baaa Compare October 16, 2020 21:17
@SuperSandro2000 SuperSandro2000 force-pushed the python-libsass branch 2 times, most recently from e21b074 to d8a79fe Compare October 18, 2020 09:51
SuperSandro2000
SuperSandro2000 commented Nov 26, 2020
View reviewed changes
pkgs/development/python-modules/libsass/default.nix Outdated
Comment on lines 36 to 37
};

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
};
};

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 100521 run on x86_64-linux 1

3 packages built:
  • python27Packages.libsass
  • python37Packages.libsass
  • python38Packages.libsass

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 100521 run on x86_64-darwin 1

3 packages built:
  • python27Packages.libsass
  • python37Packages.libsass
  • python38Packages.libsass

@SuperSandro2000 SuperSandro2000 merged commit b1cff04 into NixOS:master Nov 26, 2020
@SuperSandro2000 SuperSandro2000 deleted the python-libsass branch November 26, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @jonringer