pawn: init at 4.0.5749 #100531
Closed
pawn: init at 4.0.5749 #100531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberth
reviewed
Nov 5, 2020
Comment on lines
+39
to
+42
| { | ||
| fullName = "An exception clause to explicitly permit static linking of the library to commercial application"; | ||
| url = "https://www.compuphase.com/pawn/pawn.htm#APACHE_EXCEPTION"; | ||
| } |
There was a problem hiding this comment.
@alyssais, how should this be represented?
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
AndersonTorres
suggested changes
Nov 25, 2020
| sha256 = "1qj2n0xql2bmgvng7q7xf7113bgi2kqgaq9jp0dmys3nc3vm123f"; | ||
| stripRoot = false; | ||
| }; | ||
| buildInputs = with pkgs; [ cmake gcc_multi ]; |
There was a problem hiding this comment.
Why not to declare them on function arguments?
Also, cmake usually goes in nativeBuildInputs.
| were essential design criterions for both the language and the abstract | ||
| machine. | ||
| ''; | ||
| homepage = https://www.compuphase.com/pawn/pawn.htm; |
There was a problem hiding this comment.
Put double quotes in the HTTP link strings.
| url = "https://www.compuphase.com/${pname}/${pname}-${version}.zip"; | ||
| sha256 = "1qj2n0xql2bmgvng7q7xf7113bgi2kqgaq9jp0dmys3nc3vm123f"; | ||
| stripRoot = false; | ||
| }; |
There was a problem hiding this comment.
A cosmetic whitespace here, please.
SuperSandro2000
requested changes
Jan 18, 2021
| @@ -6539,6 +6539,12 @@ | |||
| githubId = 1788628; | |||
| name = "pandaman"; | |||
| }; | |||
| panurg = { | |||
There was a problem hiding this comment.
Please put this into a separate commit with the message maintainers: add panurg.
| @@ -0,0 +1,47 @@ | |||
| { stdenv, fetchzip, pkgs }: | |||
| cp *.so $out/lib | ||
| ''; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with stdenv.lib; { | |
| meta = with lib; { |
|
I have tried it but it does not work. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Just another scripting language and its compiler, VM libraries and some useful tools.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)