Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] pythonPackages.cma: 2.7.0 -> 3.0.3 #100517

Merged
merged 1 commit into from Oct 15, 2020
Merged

[20.09] pythonPackages.cma: 2.7.0 -> 3.0.3 #100517

merged 1 commit into from Oct 15, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 14, 2020

Motivation for this change

ZHF: #97479

Backport of #87293.

Reverse dependency optuna is already broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from costrouc October 14, 2020 20:24
@bhipple
Copy link
Contributor

bhipple commented Oct 15, 2020

Result of nixpkgs-review pr 100517 1

4 packages failed to build:
- python27Packages.cma
- python37Packages.cma
- python37Packages.optuna
- python38Packages.cma

@risicle
Copy link
Contributor Author

risicle commented Oct 15, 2020

@ofborg build python37Packages.cma python38Packages.cma python27Packages.cma

jonringer
jonringer approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/100517
1 package failed to build:
python37Packages.optuna

3 packages built:
python27Packages.cma python37Packages.cma python38Packages.cma

@jonringer jonringer merged commit 848f952 into NixOS:release-20.09 Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@risicle @bhipple @jonringer @r-ryantm