Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starboard: 0.5.0 -> 0.6.0 #100524

Merged
merged 1 commit into from Nov 5, 2020
Merged

starboard: 0.5.0 -> 0.6.0 #100524

merged 1 commit into from Nov 5, 2020

Conversation

06kellyjac
Copy link
Member

Motivation for this change

Bump starboard to 0.6.0

Also only package starboard, there is now also starboard-operator and starboard-scanner-aqua

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
starboard: 0.5.0 -> 0.6.0
bf422f5 
Also set subPackages to "cmd/starboard" as there is now also
starboard-operator and starboard-scanner-aqua.
@ofborg ofborg bot requested a review from kalbasit October 14, 2020 21:20
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/346

@roberth
Copy link
Member

roberth commented Nov 5, 2020

Thank you @06kellyjac!

@roberth roberth merged commit 2d3c2e1 into NixOS:master Nov 5, 2020
@06kellyjac 06kellyjac deleted the starboard_0.6.0 branch November 5, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@06kellyjac @nixos-discourse @roberth