Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pytest-flask: remove support for python 2.7 #100525

Merged
merged 1 commit into from Oct 17, 2020
Merged

python3Packages.pytest-flask: remove support for python 2.7 #100525

merged 1 commit into from Oct 17, 2020

Conversation

jfroche
Copy link
Contributor

@jfroche jfroche commented Oct 14, 2020 •
edited

As stated in its changelog [1], python 2.7 is no longer supported.

[1] https://github.com/pytest-dev/pytest-flask/blob/master/docs/changelog.rst

ZHF: #97479
@NixOS/nixos-release-managers

Fixes https://hydra.nixos.org/build/127652828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jfroche jfroche changed the title python3Package.pytest-flask: remove support for python 2.7 python3Packages.pytest-flask: remove support for python 2.7 Oct 14, 2020
@jfroche
Copy link
Contributor Author

jfroche commented Oct 14, 2020

Result of nixpkgs-review pr 100525 1

@ofborg ofborg bot requested a review from vanschelven October 16, 2020 19:47
jonringer
jonringer approved these changes Oct 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 100525 1

5 packages built:
  • flexget
  • python37Packages.flask-restx
  • python37Packages.pytest-flask
  • python38Packages.flask-restx
  • python38Packages.pytest-flask

@jonringer jonringer merged commit e07cf5d into NixOS:master Oct 17, 2020
@jfroche jfroche mentioned this pull request Oct 18, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@vanschelven vanschelven Awaiting requested review from vanschelven

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfroche @jonringer