Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nvidia: decouple nvidia_x11.persistenced #100538

Merged
merged 1 commit into from Oct 18, 2020
Merged

nixos/nvidia: decouple nvidia_x11.persistenced #100538

merged 1 commit into from Oct 18, 2020

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Oct 15, 2020

Motivation for this change

glibc 2.32 removed rpc/rpc.h so package broke

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bkchr
bkchr approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@bkchr
Copy link
Contributor

bkchr commented Oct 15, 2020

But is is probably better to fix the package?

@eadwu
Copy link
Member Author

eadwu commented Oct 15, 2020

Broken upstream, nor do I wish to devote the time to convert the protocol to an entirely new one without any experience.

@bkchr
Copy link
Contributor

bkchr commented Oct 16, 2020

Sounds fine, but than we should tag the package as broken?

@bkchr
Copy link
Contributor

bkchr commented Oct 18, 2020

#100991 fixes the build of the broken package.

@eadwu eadwu closed this Oct 18, 2020
@jonringer
Copy link
Contributor

hmm, although my PR fixed the build, the application just crashes

maybe this is the correct way forward until upstream adjusts

@jonringer
Copy link
Contributor

This PR is more coherent anyway, nvidia-persistenced wouldn't do much wihtout the related service, so I'm not sure why we are blindly installing it for all users.

@jonringer jonringer reopened this Oct 18, 2020
@jonringer jonringer merged commit 2e67196 into NixOS:master Oct 18, 2020
@hazelweakly hazelweakly mentioned this pull request Oct 29, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @bkchr @jonringer