melmatcheq.lv2: init at 0.1 #102743
Merged
melmatcheq.lv2: init at 0.1 #102743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sikmir
reviewed
Nov 4, 2020
magnetophon
force-pushed
the
melmatcheq.lv2
branch
from
d15a1dc
to
de978a1
Compare
|
And why labeled ofborg this as 0 builds for darwin and linux? |
magnetophon
force-pushed
the
melmatcheq.lv2
branch
from
de978a1
to
22224a5
Compare
|
@SuperSandro2000 Maybe because I didn't have meta.platform defined? Seems OK now, right? |
|
Result of |
| sha256 = "1s805jgb9msxfq9047s7pxrngizb00w8sm4z94iii80ba65rd20x"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig ]; |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ pkgconfig ]; | |
| nativeBuildInputs = [ pkg-config ]; |
| @@ -0,0 +1,28 @@ | |||
| { stdenv, fetchFromGitHub, xorg, xorgproto, cairo, lv2, pkgconfig }: | |||
There was a problem hiding this comment.
Suggested change
| { stdenv, fetchFromGitHub, xorg, xorgproto, cairo, lv2, pkgconfig }: | |
| { stdenv, fetchFromGitHub, xorg, xorgproto, cairo, lv2, pkg-config }: |
There was a problem hiding this comment.
Ah, yes, thanks.
Out of curiosity: is there a reason to not do a tree-wide replace of pkgconfig for pkg-config, except for the alias?
I usually start new pkgs by copying a similar existing one and adapting it, so this kind of error is easy to creep in.
I can't imagine I'm the only one doing this.
|
Result of |
magnetophon
force-pushed
the
melmatcheq.lv2
branch
from
22224a5
to
65a524b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)