Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] zsh: 5.7.1 -> 5.8 #102762

Closed
wants to merge 1 commit into from
Closed

[20.03] zsh: 5.7.1 -> 5.8 #102762

wants to merge 1 commit into from

Conversation

redvers
Copy link
Member

@redvers redvers commented Nov 4, 2020

Backport of #80227 for nixos-20-03

Fixes #91037

It's comments are repeated below. I cherry-picked and tested it.

https://www.zsh.org/mla/zsh-announce/141

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from pSub November 4, 2020 14:24
@redvers redvers changed the title zsh: 5.7.1 -> 5.8 zsh: 5.7.1 -> 5.8 [20.03] Nov 5, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102762 run on x86_64-linux 1

1 package marked as broken and skipped:
  • aliceml
8 packages built:
  • grml-zsh-config
  • haskellPackages.hapistrano
  • lambda-mod-zsh-theme
  • passExtensions.pass-tomb
  • tomb
  • zsh
  • zsh-autosuggestions
  • zsh-syntax-highlighting

@redvers
Copy link
Member Author

redvers commented Nov 6, 2020

@andir

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102762 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • passExtensions.pass-tomb
5 packages built:
  • grml-zsh-config
  • haskellPackages.hapistrano
  • zsh
  • zsh-autosuggestions
  • zsh-syntax-highlighting

@SuperSandro2000 SuperSandro2000 changed the title zsh: 5.7.1 -> 5.8 [20.03] [20.03] zsh: 5.7.1 -> 5.8 Nov 24, 2020
@SuperSandro2000
Copy link
Member

@pSub friendly ping

@mweinelt
Copy link
Member

Thank you for your contribution. Unfortunately it is not in a state to be merged as-is (missing reference to cherry-picked commit), and NixOS 20.03 is EOL as of today.

Closing.

@mweinelt mweinelt closed this Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@redvers @SuperSandro2000 @mweinelt @zowoq