Skip to content

[20.09] mediawiki: update 1.34.2 -> 1.34.4 #102706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2020
Merged

[20.09] mediawiki: update 1.34.2 -> 1.34.4 #102706

merged 1 commit into from
Nov 4, 2020
+2 −2

Conversation

redvers
Copy link
Member

@redvers redvers commented Nov 4, 2020 •
edited
Loading

Motivation for this change

Bringing this up to current - same version that is in current master.

Fixes Security Issues:
#100310

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Nov 4, 2020
@redvers redvers mentioned this pull request Nov 4, 2020
Closed
10 tasks
@mweinelt
Copy link
Member

mweinelt commented Nov 4, 2020

Is bumping the mediawiki version the only supported way to fix those issues?

@SuperSandro2000
Copy link
Member

Is bumping the mediawiki version the only supported way to fix those issues?

They are also fixed in 1.34.4 which could be backported.

@mweinelt
Copy link
Member

mweinelt commented Nov 4, 2020

Then let's stay the 1.34.x release cycle.

@redvers
Copy link
Member Author

redvers commented Nov 4, 2020

Sounds good - will do.

@redvers redvers force-pushed the update_mediawiki_1.35.0 branch from 6268e6b to 0b9702b Compare November 4, 2020 18:11
@redvers redvers changed the title mediawiki: update 1.35.0 mediawiki: update 1.34.4 Nov 4, 2020
@mweinelt
Copy link
Member

mweinelt commented Nov 4, 2020

@GrahamcOfBorg test mediawiki

@mweinelt mweinelt changed the title mediawiki: update 1.34.4 [20.09] mediawiki: update 1.34.4 Nov 4, 2020
mweinelt
mweinelt requested changes Nov 4, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please recheck that you're following https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md. The commit message, for example, is off.

@redvers redvers force-pushed the update_mediawiki_1.35.0 branch from 0b9702b to 9b63830 Compare November 4, 2020 19:05
@redvers
Copy link
Member Author

redvers commented Nov 4, 2020

Please recheck that you're following https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md. The commit message, for example, is off.

Okay - dealt with that.

Do I need to worry about the now mis-named branchnames? If so, I have no idea how to rename the branches locally, remotely, and to assure that it doesn't automatically close the PR (which is what happened last time I tried to rename them)

@redvers redvers changed the title [20.09] mediawiki: update 1.34.4 [20.09] mediawiki: update 1.34.2 -> 1.34.4 Nov 4, 2020
@mweinelt
Copy link
Member

mweinelt commented Nov 4, 2020

The commit message is still off:

- mediawiki: update 1.34.2 -> 1.34.4 
+ mediawiki: 1.34.2 -> 1.34.4

Your branch name is immaterial after merging this, don't worry about it.

@mweinelt mweinelt added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 4, 2020
@redvers redvers force-pushed the update_mediawiki_1.35.0 branch from 9b63830 to 60544f9 Compare November 4, 2020 19:23
@redvers
Copy link
Member Author

redvers commented Nov 4, 2020 

- mediawiki: update 1.34.2 -> 1.34.4 
+ mediawiki: 1.34.2 -> 1.34.4

Thanks for taking the time to sweat the details. I'm working my way through all the rest of the PRs I've opened which have similar issues.

Appreciate it.

@mweinelt mweinelt merged commit a6a3a36 into NixOS:release-20.09 Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@redvers @mweinelt @SuperSandro2000