Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixos-homepage
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3815fc838668
Choose a base ref
...
head repository: NixOS/nixos-homepage
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1cd0f1368a16
Choose a head ref
  • 9 commits
  • 9 files changed
  • 2 contributors

Commits on Nov 4, 2020

  1. site-styles: Add site-width rulers in debug mode

    @samueldr
    samueldr committed Nov 4, 2020
    Copy the full SHA
    badd595 View commit details

  2. site-styles: Use margins rather than paddings for columns 

    The padding would end up causing a mis-alignment of columns.

The `calc()` is needed here as the total space available is 100%, but if
we don't remove it from the width of the elements we'd end up with
100%+n*margin
    @samueldr
    samueldr committed Nov 4, 2020
    Copy the full SHA
    385f18f View commit details

  3. layout: Review footer to use columns and container mixins 

    It seems the previous method didn't compose well.

It would end up creating a bit of padding where there shouldn't be since
using #container() at the same place as #columns() can't work.
    @samueldr
    samueldr committed Nov 4, 2020
    Copy the full SHA
    f8b2dbc View commit details

  4. site-styles: Add debugging bounding boxes to flex-flexible mixins

    @samueldr
    samueldr committed Nov 4, 2020
    Copy the full SHA
    f1f7ad8 View commit details

  5. site-styles: Remove NixOS text from the navbar on narrow sm widths 

    There's too many items in the menu when bordering on xs.
    @samueldr
    samueldr committed Nov 4, 2020
    Copy the full SHA
    85ea638 View commit details

  6. site-styles: Fix regression in community.less 

    Setting all margins like that breaks #columns()
    @samueldr
    samueldr committed Nov 4, 2020
    Copy the full SHA
    0d29d66 View commit details

  7. site-styles: Fix scrolling bug at ==768px width 

    The negative margins being applied all the time caused issues when the
total width of the viewport was smaller than the site width + those
margin sizes.
    @samueldr
    samueldr committed Nov 4, 2020
    Copy the full SHA
    d9200eb View commit details

  8. site-style: Fix fallout from changing columns implementation 

    The way this is fixed also better explains what the desire is. We
actually want three columns, not two. It's only that we want the second
column to span two out of the three columns.

We will need an abstraction over that.
    @samueldr
    samueldr committed Nov 4, 2020
    Copy the full SHA
    a1f44e0 View commit details

  9. Merge pull request #636 from NixOS/fix/misc-columns-and-alignment 

    misc. alignments and columns fixes
    @garbas
    garbas authored Nov 4, 2020
    1
    Copy the full SHA
    1cd0f13 View commit details
Loading