Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inkcut: 2.1.1 -> 2.1.2 #102754

Merged
merged 1 commit into from Nov 20, 2020
Merged

inkcut: 2.1.1 -> 2.1.2 #102754

merged 1 commit into from Nov 20, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Nov 4, 2020

Motivation for this change

Mainly improved Inkscape 1.0 support and fixes for elliptic curves
(inkcut/inkcut#263)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

wasn't able to test with an actual cutter due to covid, but the GUI
starts correctly

@raboof
inkcut: update to 2.1.2
ef2333f 
wasn't able to test with an actual cutter due to covid, but the GUI
starts correctly
@raboof raboof changed the title inkcut: update to 2.1.2 inkcut: 2.1.1 -> 2.1.2 Nov 4, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102754 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • inkcut

@raboof
Copy link
Member Author

raboof commented Nov 6, 2020

Result of nixpkgs-review pr 102754 run on x86_64-darwin 1
1 package marked as broken and skipped:

It is 'broken' because we don't support darwin, right?

(actually it might work on darwin, but I don't have a machine to test that on...)

@SuperSandro2000
Copy link
Member

It is 'broken' because we don't support darwin, right?

It can't be build because one of the dependencies can't be build on darwin.

@raboof
Copy link
Member Author

raboof commented Nov 9, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 9, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

timokau
timokau approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you :)

@timokau timokau merged commit e073243 into NixOS:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raboof @SuperSandro2000 @timokau