Skip to content

[20.09] sddm: add patch for CVE-2020-28049 #102760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2020
Merged

[20.09] sddm: add patch for CVE-2020-28049 #102760

merged 1 commit into from
Nov 24, 2020
+6 −1

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 4, 2020

Motivation for this change

Local privilege escalation due to race condition in creation of the Xauthority file.

https://www.openwall.com/lists/oss-security/2020/11/04/2

Fixes: CVE-2020-28049

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mweinelt
sddm: add patch for CVE-2020-28049
faf436e 
> Local privilege escalation due to race condition in creation of the Xauthority file.

Fixes: CVE-2020-28049
@mweinelt mweinelt added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 4, 2020
@mweinelt
Copy link
Member Author

mweinelt commented Nov 4, 2020

Looks like this changeset applies to 20.03 as well, so when merged I'll pick this commit.

@ofborg ofborg bot requested review from abbradar and ttuegel November 4, 2020 12:59
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 4, 2020
@mweinelt mweinelt merged commit 8c5df6d into NixOS:release-20.09 Nov 24, 2020
@mweinelt mweinelt deleted the 20.09/sddm branch November 24, 2020 19:37
@ttuegel ttuegel mentioned this pull request Jan 2, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar

@ttuegel ttuegel

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: qt/kde 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @FRidh