Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frama-c: small tweaks #102733

Merged
merged 2 commits into from Nov 7, 2020
Merged

Frama-c: small tweaks #102733

merged 2 commits into from Nov 7, 2020

Conversation

symphorien
Copy link
Member

Motivation for this change
  • frama-c-gui does not work in nix-bundle because GDK_PIXBUF_MODULE_FILE is not wrapped
  • nix-review fails on frama-c because the setupHook fails when FRAMAC_PLUGIN is undefined
Things done
  • use wrappGAppsHook
  • fix the setuphook
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @thoughtpolice @amiddelk as maintainers

@symphorien
framac: use wrapGAppsHook
4a45128 
this solves a gdk-pixbuf related problem when using nix-bundle
@symphorien
framac: fix setup hook without plugins in nix-review
b36f99d
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102733 run on x86_64-linux 1

1 package built:
  • framac

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102733 run on x86_64-darwin 1

1 package built:
  • framac

@bjornfor bjornfor merged commit 3dd8f8e into NixOS:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@amiddelk amiddelk Awaiting requested review from amiddelk

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@symphorien @SuperSandro2000 @bjornfor