Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediawiki: update 1.34.0 -> 1.34.4 [20.03] #102708

Closed

Conversation

redvers
Copy link
Member

@redvers redvers commented Nov 4, 2020

Motivation for this change

Bringing this up to current - same version that is in current master. (see #102706 for 20.09)

Fixes Security Issues:
#100309 #99810 #92873 #90881

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Are there breaking changes? If so it is maybe a better idea to update to 1.34.4.

@redvers
Copy link
Member Author

redvers commented Nov 4, 2020

Concur - switching to 1.34.4

@redvers redvers force-pushed the update_mediawiki_2003_to_1.35.0 branch from bc23823 to 089e6ff Compare November 4, 2020 18:29
@redvers redvers changed the title mediawiki: update nixos-20.03 to 1.35.0 mediawiki: update nixos-20.03 to 1.34.4 Nov 4, 2020
@redvers redvers changed the title mediawiki: update nixos-20.03 to 1.34.4 mediawiki: update 1.34.0 -> 1.34.4 Nov 4, 2020
@redvers redvers force-pushed the update_mediawiki_2003_to_1.35.0 branch from 089e6ff to 6152c52 Compare November 4, 2020 19:09
@redvers redvers force-pushed the update_mediawiki_2003_to_1.35.0 branch from 6152c52 to eda5f6a Compare November 4, 2020 19:24
@redvers redvers changed the title mediawiki: update 1.34.0 -> 1.34.4 mediawiki: update 1.34.0 -> 1.34.4 [20.03] Nov 5, 2020
@redvers
Copy link
Member Author

redvers commented Nov 6, 2020

@andir

@andir
Copy link
Member

andir commented Nov 9, 2020

This is targeting the wrong branch. It should go to release-20.03. nixos-20.03 is here to reflect what has passed hydra.

While add it please add more context to the commit message.

@redvers redvers changed the base branch from nixos-20.03 to release-20.03 November 23, 2020 14:59
@mweinelt
Copy link
Member

If these version bumps already exist on release-20.09 or master, please backport them from there.

@mweinelt
Copy link
Member

Thank you for your contribution. Unfortunately it is not in a state to be merged as-is, and NixOS 20.03 is EOL as of today.

Closing.

@mweinelt mweinelt closed this Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants