Skip to content

CODEOWNERS: maintainers for dockerTools #102749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Nov 4, 2020

Motivation for this change

The dockerTools currently don't have any documented maintainers. Maintainers for functions go into the CODEOWNERS file.

Would you want to be listed as dockerTools maintainer?

cc recent contributors that made multiple/larger changes @roberth @utdemir @zowoq @nlewo @adisbladis @nagisa @grahamc

@FRidh FRidh added the 2.status: work-in-progress This PR isn't done label Nov 4, 2020
@ofborg ofborg bot added 6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 4, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@FRidh FRidh changed the title WIP: CODEOWNERS: maintainers for dockerTools CODEOWNERS: maintainers for dockerTools Nov 6, 2020
@FRidh FRidh marked this pull request as ready for review November 6, 2020 09:11
@FRidh FRidh requested a review from edolstra as a code owner November 6, 2020 09:11
@FRidh FRidh merged commit af7f9e5 into NixOS:master Nov 6, 2020
@FRidh
Copy link
Member Author

FRidh commented Nov 6, 2020

Thank you @roberth . Anyone else can of course open a PR adding themselves as well.

@FRidh FRidh deleted the codeowners-docker-tools branch November 6, 2020 09:12
@nlewo
Copy link
Member

nlewo commented Nov 6, 2020

I'm currently no longer building Docker images with Nix, but i would be happy to open a PR if i work on this topic again.

@utdemir
Copy link
Member

utdemir commented Nov 8, 2020

Hey, sorry I did not see this. Yes, I probably should be a code owner for streamLayeredImage stuff. I created a PR adding myself: #103175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: work-in-progress This PR isn't done 6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants