Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.empyrical: init at 0.5.5 #102721

Closed
wants to merge 1 commit into from
Closed

Conversation

evax
Copy link
Contributor

@evax evax commented Nov 4, 2020

Motivation for this change

Common financial risk metrics

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102721 run on x86_64-linux 1

2 packages built:
  • python37Packages.empyrical
  • python38Packages.empyrical

substituteInPlace empyrical/tests/test_perf_attrib.py --replace \
" def test_perf_attrib_simple(self):" \
' @unittest.skip("known to fail")
def test_perf_attrib_simple(self):'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests don't work with pytest?

homepage = "https://quantopian.github.io/empyrical/";
license = licenses.asl20;
maintainers = with maintainers; [ evax ];
platforms = platforms.unix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required in buildPythonPackage.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102721 run on x86_64-linux 1

2 packages built:
  • python37Packages.empyrical
  • python38Packages.empyrical

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102721 run on x86_64-darwin 1

2 packages built:
  • python37Packages.empyrical
  • python38Packages.empyrical

${python.interpreter} runtests.py
'';

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

@stale
Copy link

stale bot commented Jul 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 26, 2021
@Artturin
Copy link
Member

Artturin commented Feb 2, 2023

Reopen and rebase if you're still interested in this.

@Artturin Artturin closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants