Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.apron: split into multiple outputs #102720

Merged
merged 1 commit into from Nov 6, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 4, 2020

Motivation for this change

Smaller closure of programs using apron.

For instance, here are the sizes of the closures of ikos:

  • before: 2,303,402,704
  • after: 1,942,264,344

In particular (in this example), OCaml and MPFR-dev have been removed from the closure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Comment on lines +26 to +27
mkdir -p $dev/lib
mv $out/lib/ocaml $dev/lib/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use install here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install -Dm555 $out/lib/ocaml $dev/lib

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But install does not remove the source, does it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it does not. I this required here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It is the very purpose of this PR.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102720 run on x86_64-linux 1

2 packages built:
  • framac
  • ikos

@ehmry ehmry merged commit 63aa105 into NixOS:master Nov 6, 2020
@vbgl vbgl deleted the ocaml-apron-split branch November 6, 2020 09:10
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102720 run on x86_64-darwin 1

1 package built:
  • framac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants