Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtcurve, kde2-decoration: fix for Qt 5.15 #102727

Closed
wants to merge 4 commits into from
Closed

qtcurve, kde2-decoration: fix for Qt 5.15 #102727

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 4, 2020 •
edited by ghost

Motivation for this change

After #97242
cc @ttuegel

Tested under plasma5 (qt5) and lxqt (qt514)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

gnidorah added 4 commits November 4, 2020 10:43
kde2-decoration: 1.0 -> 1.1
ed0cea9
qtcurve: fix build for qt 5.15
a6f3694
kde2-decoration: move to libsForQt5
4c4976a 
its a kdecoration plugin like breeze-qt5 or oxygen
qtcurve: move to libsForQt5
d1946fd 
its a theme engine like qtstyleplugin-kvantum
@ghost
Copy link
Author

ghost commented Nov 4, 2020

Result of nixpkgs-review pr 102727 1

6 packages built:
  • libsForQt5.kde2-decoration
  • libsForQt5.qtcurve
  • libsForQt512.kde2-decoration
  • libsForQt512.qtcurve
  • libsForQt514.kde2-decoration
  • libsForQt514.qtcurve

@ghost ghost marked this pull request as ready for review November 4, 2020 08:02
@FRidh FRidh added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 6, 2020
@ghost
Copy link
Author

ghost commented Nov 8, 2020

Should be superseeded by #102840

@ghost
Copy link
Author

ghost commented Nov 21, 2020

Closing since #102840 got merged

@ghost ghost closed this Nov 21, 2020
@ghost ghost deleted the qt branch November 21, 2020 05:30
@erictapen
Copy link
Member

@ghost This was superseeded in #102840, but the fixes you propose here were not backported. What do you think, would it be worth the work? Or should we remove the needs: port to stable label?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @FRidh @doronbehar