Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libhandy: 1.0.0 -> 1.0.1, reenable checks #102752

Merged
merged 1 commit into from Nov 4, 2020
Merged

libhandy: 1.0.0 -> 1.0.1, reenable checks #102752

merged 1 commit into from Nov 4, 2020

Conversation

wamserma
Copy link
Member

@wamserma wamserma commented Nov 4, 2020

Motivation for this change

Bump to latest version, fix checkPhase.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wamserma wamserma mentioned this pull request Nov 4, 2020
Closed
10 tasks
@wamserma wamserma requested a review from jtojnar November 4, 2020 12:40
@worldofpeace worldofpeace merged commit cc30c16 into NixOS:staging Nov 4, 2020
@worldofpeace
Copy link
Contributor

Thanks for pushing this @wamserma ✨

@jtojnar
Copy link
Contributor

jtojnar commented Nov 5, 2020 •
edited

Changes look okay: https://gitlab.gnome.org/GNOME/libhandy/-/tags/1.0.1

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Nov 5, 2020
@wamserma wamserma deleted the libhandy-101-staging branch November 5, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wamserma @worldofpeace @jtojnar