Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rmlint: Use Python3 sphinx for docs #102025

Merged
merged 1 commit into from Oct 30, 2020

Conversation

braunse
Copy link
Contributor

@braunse braunse commented Oct 29, 2020

Eliminates a python2 dependency.

Motivation for this change

Using python3 sphinx gets rid of a python2 dependency, see #101964.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Closure size unchanged:

/nix/store/5m7lxqd2a9wivgard7r839fgylm1ak1w-rmlint-2.10.1          61062360
/nix/store/9jwrg48l450wmjipw7i6v4igr5ia9lbk-rmlint-2.10.1          61062360

Eliminates a python2 dependency.
@braunse
Copy link
Contributor Author

braunse commented Oct 29, 2020

Result of nixpkgs-review pr 102025 1

1 package built:
  • rmlint

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 102025 1

1 package built:
  • rmlint

@jonringer jonringer merged commit c0bcfeb into NixOS:master Oct 30, 2020
@braunse braunse deleted the patch-rmlint-python2-dep branch October 30, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants