Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fortune-mod: 2.10.0 -> 3.2.0 #102027

Merged
merged 1 commit into from
Nov 8, 2020
Merged

fortune-mod: 2.10.0 -> 3.2.0 #102027

merged 1 commit into from
Nov 8, 2020
+7 −4

Conversation

Vonfry
Copy link
Member

@Vonfry Vonfry commented Oct 29, 2020 •
edited
Loading

Motivation for this change

Update and add update script as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 29, 2020
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 29, 2020 •
edited
Loading

Result of nixpkgs-review pr 102027 run on x86_64-linux 1

2 packages failed to build:
  • gtypist
  • xcowsay
2 packages built:
  • ding
  • fortune

Unrelated to this PR

configuring
configure flags: --disable-dependency-tracking --prefix=/nix/store/xilg2k9kqas8flrff9nfn5cdpcz19wkl-xcowsay-1.5 --enable-dbus
/nix/store/q1zjp9grl4w92qalkdqjs2bj5d0pf8ih-stdenv-linux/setup: ./configure: /bin/sh: bad interpreter: No such file or directory

@SuperSandro2000 SuperSandro2000 mentioned this pull request Oct 29, 2020
Closed
10 tasks
@Vonfry Vonfry force-pushed the update/fortune-3.2.0 branch 2 times, most recently from da604ec to 7043492 Compare October 30, 2020 02:40
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102027 run on x86_64-linux 1

4 packages built:
  • ding
  • fortune
  • gtypist
  • xcowsay

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102027 run on x86_64-darwin 1

2 packages built:
  • fortune
  • gtypist

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/353

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/281

danieldk
danieldk suggested changes Nov 7, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment on using fetchFromGitHub and making the update script unnecessary.

@Vonfry Vonfry force-pushed the update/fortune-3.2.0 branch 2 times, most recently from aaf9d7f to ab4b325 Compare November 8, 2020 09:56
@Vonfry Vonfry force-pushed the update/fortune-3.2.0 branch from ab4b325 to 7b117f1 Compare November 8, 2020 09:57
@Vonfry Vonfry requested a review from danieldk November 8, 2020 10:32
danieldk
danieldk approved these changes Nov 8, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Result of nixpkgs-review pr 102027 1

4 packages built:
  • ding
  • fortune
  • gtypist
  • xcowsay

fortune works as expected.

@danieldk danieldk merged commit 6519e0b into NixOS:master Nov 8, 2020
@Vonfry Vonfry deleted the update/fortune-3.2.0 branch November 8, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk

@ajs124 ajs124

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Vonfry @SuperSandro2000 @nixos-discourse @danieldk @ajs124