Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monero: 0.17.1.0 -> 0.17.1.1 #101985

Merged
merged 2 commits into from Oct 29, 2020
Merged

monero: 0.17.1.0 -> 0.17.1.1 #101985

merged 2 commits into from Oct 29, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 29, 2020

Motivation for this change

Important bugfix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj requested a review from mmahut as a code owner October 29, 2020 00:05
@SuperSandro2000
Copy link
Member

Can you fix the title and commit messages?

monero: 0.17.1.1 -> 0.17.1.1 => monero: 0.17.1.0 -> 0.17.1.1

@rnhmjoj rnhmjoj requested a review from prusnak October 29, 2020 00:08
@rnhmjoj rnhmjoj added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 29, 2020
@ofborg ofborg bot requested a review from ehmry October 29, 2020 00:17
@rnhmjoj rnhmjoj changed the title monero: 0.17.1.1 -> 0.17.1.1 monero: 0.17.1.0 -> 0.17.1.1 Oct 29, 2020
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Oct 29, 2020

Done, thank you.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101985 run on x86_64-darwin 1

1 package built:
  • monero

@rnhmjoj rnhmjoj merged commit df6068e into NixOS:master Oct 29, 2020
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Oct 29, 2020

Backported to 20.09: 47122ce b3bf6a4

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@prusnak prusnak Awaiting requested review from prusnak

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @SuperSandro2000 @erictapen