Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conv{bin,img,font}: init at {3.0,8.3,1.0} #102017

Merged
merged 3 commits into from Nov 2, 2020
Merged

conv{bin,img,font}: init at {3.0,8.3,1.0} #102017

merged 3 commits into from Nov 2, 2020

Conversation

luc65r
Copy link
Contributor

@luc65r luc65r commented Oct 29, 2020 •
edited

Motivation for this change

Package conv* utilities to eventually package the CE C Toolchain

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Oct 29, 2020
View reviewed changes
pkgs/tools/misc/convbin/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/convbin/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/convfont/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/convimg/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/convimg/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 29, 2020 •
edited

Result of nixpkgs-review pr 102017 run on x86_64-darwin 1

3 packages failed to build:
  • convbin
  • convfont
  • convimg

All build with similar error:

building
build flags: SHELL=/nix/store/8i9kyqfxhk2s9dzx32x0sgdk7kyx9wjc-bash-4.4-p23/bin/bash
gcc -c src/appvar.c -Wall -Wno-unused-but-set-variable -O3 -DNDEBUG -DLOG_BUILD_LEVEL=3 -flto -I./src/deps/libyaml/include -o obj/appvar.o
/nix/store/8i9kyqfxhk2s9dzx32x0sgdk7kyx9wjc-bash-4.4-p23/bin/bash: gcc: command not found
make: *** [Makefile:103: obj/appvar.o] Error 127

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102017 run on x86_64-linux 1

3 packages built:
  • convbin
  • convfont
  • convimg

@luc65r
Copy link
Contributor Author

luc65r commented Oct 29, 2020

gcc: command not found

gcc is hardcoded in the makefiles...

@luc65r
Copy link
Contributor Author

luc65r commented Oct 29, 2020

@SuperSandro2000 now it should work on darwin

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102017 run on x86_64-linux 1

3 packages built:
  • convbin
  • convfont
  • convimg

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 31, 2020 •
edited

Result of nixpkgs-review pr 102017 run on x86_64-darwin 1

1 package failed to build:
  • convimg
2 packages built:
  • convbin
  • convfont
ld: warning: ld: warning: ignoring file obj/output-c.o, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0xDE 0xC0 0x17 0x0B 0x00 0x00 0x00 0x00 0x14 0x00 0x00 0x00 0xB0 0x42 0x00 0x00 )
ignoring file obj/deps/libyaml/src/parser.o, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0xDE 0xC0 0x17 0x0B 0x00 0x00 0x00 0x00 0x14 0x00 0x00 0x00 0xB8 0x8B 0x00 0x00 )
ld: warning: ignoring file obj/deps/libyaml/src/dumper.o, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0xDE 0xC0 0x17 0x0B 0x00 0x00 0x00 0x00 0x14 0x00 0x00 0x00 0x4C 0x37 0x00 0x00 )
ld: warning: ignoring file obj/deps/libyaml/src/scanner.o, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0xDE 0xC0 0x17 0x0B 0x00 0x00 0x00 0x00 0x14 0x00 0x00 0x00 0x7C 0x65 0x01 0x00 )
ld: warning: ignoring file obj/deps/libyaml/src/loader.o, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0xDE 0xC0 0x17 0x0B 0x00 0x00 0x00 0x00 0x14 0x00 0x00 0x00 0x80 0x41 0x00 0x00 )
ld: warning: ignoring file obj/deps/libyaml/src/reader.o, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0xDE 0xC0 0x17 0x0B 0x00 0x00 0x00 0x00 0x14 0x00 0x00 0x00 0xAC 0x2E 0x00 0x00 )
Undefined symbols for architecture x86_64:
  "_main", referenced from:
     implicit entry/start for main executable
ld: symbol(s) not found for architecture x86_64
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:87: bin/convimg] Error 1
builder for '/nix/store/226hmyqiqzvm4ziq4f227bm4zixvsqyi-convimg-8.3.drv' failed with exit code 2
error: build of '/nix/store/226hmyqiqzvm4ziq4f227bm4zixvsqyi-convimg-8.3.drv' failed

@SuperSandro2000
Copy link
Member

@luc65r I would be fine with disabling it on darwin.

mkg20001
mkg20001 approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@mkg20001 mkg20001 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally

@mkg20001 mkg20001 merged commit 8c3d91f into NixOS:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@mkg20001 mkg20001 mkg20001 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luc65r @SuperSandro2000 @mkg20001