Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockbook-frontend: fix&update extraConfig example #102018

Merged
merged 1 commit into from Oct 30, 2020
Merged

blockbook-frontend: fix&update extraConfig example #102018

merged 1 commit into from Oct 30, 2020

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Oct 29, 2020

Motivation for this change

Provide better and correct (missing quotes) example for Bitcoin configuration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@1000101
Copy link
Member Author

1000101 commented Oct 29, 2020

@GrahamcOfBorg test blockbook-frontend

@bhipple bhipple merged commit e007520 into NixOS:master Oct 30, 2020
@1000101 1000101 deleted the blockbook-frontend branch October 30, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@1000101 @bhipple