Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nanopb: 0.4.1 -> 0.4.3 #101988

Merged
merged 1 commit into from Nov 26, 2020
Merged

nanopb: 0.4.1 -> 0.4.3 #101988

merged 1 commit into from Nov 26, 2020

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Updates nanopb to the latest version. Upstream changes allow us to remove most of the hacks from the package. All the passthru.tests succeed.

cc @kalbasit

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lopsided98
nanopb: 0.4.1 -> 0.4.3
e379149 
Upstream changes allow us to remove most of the hacks from the package.
@ofborg ofborg bot requested a review from kalbasit October 29, 2020 00:51
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101988 run on x86_64-darwin 1

1 package built:
  • nanopb

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101988 run on x86_64-linux 1

1 package built:
  • nanopb

@SuperSandro2000 SuperSandro2000 merged commit b42009a into NixOS:master Nov 26, 2020
@lopsided98 lopsided98 deleted the nanopb-update branch November 26, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopsided98 @SuperSandro2000