Skip to content

nixos/murmur: add murmur group, don't run as nogroup #102015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2020
Merged

nixos/murmur: add murmur group, don't run as nogroup #102015

merged 1 commit into from
Oct 29, 2020
+6 −1

Conversation

pstn
Copy link
Contributor

@pstn pstn commented Oct 29, 2020 •
edited
Loading

fixes #101980
ping #55370

Needs to be merged into 20.09 channel since it pretty much breaks murmur there for a lot of deployments.

Motivation for this change

It was broken, yo!

Maintainers

@petabyteboy
@infinisil

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 29, 2020
lheckemann
lheckemann approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@lheckemann lheckemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm not sure we actually need a static gid for murmur?

@pstn
Copy link
Contributor Author

pstn commented Oct 29, 2020 •
edited
Loading

The gid was "reserved" anyway because it's equal to the uid, so why not use it? Having it static could be useful in some migration scenarios and for example when generating certs externally and bind mounting them into a container or supplying them via nfs.

For example I generate letsencrypt certs in a container that only runs my authority dns. This enables me to generate certs for other containers with the right uid simply by doing

[...]
users.groups.murmur.gid = config.ids.gids.murmur;
security.acme = {
[...]
        certs."mumble.example.com" = {
          dnsProvider = "exec";
          credentialsFile = pkgs.writeText "env" "EXEC_PATH=${dnstool}/bin/update-dns.sh";
          group = "murmur";
        };
[...]

@lheckemann lheckemann merged commit a38590d into NixOS:master Oct 29, 2020
@lheckemann
Copy link
Member

20.09: da973f9

@pstn pstn deleted the murmur-group branch October 29, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Murmur can't read generated acme keys in 20.09
2 participants
@pstn @lheckemann