Skip to content

gitlab: Update update.py for the upstream change in repo name #101992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gitlab: Update update.py for the upstream change in repo name #101992

wants to merge 1 commit into from
+20 −14

Conversation

RedL0tus
Copy link

Motivation for this change

GitLab has split the CE distribution to another repository named
gitlab-foss, making the script unable to find CE releases.

This change also added a -ee option to toggle between using
GitLab EE or GitLab CE.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This PR does not contain any direct change to the GitLab package, and I've done the test for fetching updates, it should work just fine.

I'll open another PR to update GitLab to the newest version once I've done the testing.

Sorry, something went wrong.

@RedL0tus
gitlab: Update update.py for the upstream change in repo name
600734d 
GitLab has split the CE distribution to another repository named
`gitlab-foss`, making the script unable to find CE releases.

This change also added a `-ee` option to toggle between using
GitLab EE or GitLab CE.

Signed-off-by: Kay Lin <i@v2bv.net>
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 29, 2020
@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@talyz
Copy link
Contributor

talyz commented Jun 3, 2021

Sorry for the slow response. I don't think this is necessary, since we remove the proprietary code when we build the gitlab package. At least, GitLab said that the all proprietary code was relegated to the ee directory in the repo and that the -foss repo is just a read-only version of it with the ee directory filtered out. Did this change?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@RedL0tus
Copy link
Author

RedL0tus commented Jun 9, 2021 •
edited
Loading

@talyz

Sorry for the slow response.

Sorry for the late response as well, LOL.

At least, GitLab said that the all proprietary code was relegated to the ee directory in the repo and that the -foss repo is just a read-only version of it with the ee directory filtered out.

I did this change is because the version info reported in the program says it's EE. I'm kind of concerned about this.

I agree it is not a necessity but an augmentation though.

@talyz talyz mentioned this pull request Jun 9, 2021
Merged
11 tasks
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RedL0tus @talyz @Janik-Haag