Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numix-cursor-theme: patch inkscape command #102007

Merged
merged 1 commit into from Nov 3, 2020
Merged

numix-cursor-theme: patch inkscape command #102007

merged 1 commit into from Nov 3, 2020

Conversation

stephaneyfx
Copy link
Contributor

Motivation for this change

The generated cursor files were previously empty due to inkscape rejecting the command line argument. See #98481.

Things done

The theme is patched with a pending PR to upstream to use the long flags that are supported by both inkscape 0.x and 1.x.

Before this change, the generated cursor files have a size of zero. After this change, the cursors are valid and appear when selecting the theme.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from offlinehacker October 29, 2020 08:47
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 29, 2020 •
edited

Result of nixpkgs-review pr 102007 run on x86_64-darwin 1

1 package failed to build:
  • numix-cursor-theme
hash mismatch in fixed-output derivation '/nix/store/1wbjd2lglw8c8van7sbkzplixfdf077m-support-inkscape-1-in-numix-cursor-theme.patch':
  wanted: sha256:1cv6sj7jaf459p195x2brjwyim1j61586jywvgw4y3m37yv3ipa2
  got:    sha256:174kmhlvv76wwvndkys78aqc32051sqg3wzc0xg6b7by4agrbg76

@stephaneyfx stephaneyfx force-pushed the fix-numix-cursor-theme-generation branch from bf703ff to d1cf7bd Compare October 29, 2020 20:05
@stephaneyfx
numix-cursor-theme: patch inkscape command
d1cf7bd 
The generated cursor files were previously empty due to inkscape rejecting the command line argument. See NixOS#98481.
@stephaneyfx
Copy link
Contributor Author

Sorry for the mistake with the hashes. I was bitten by #41401 (comment). Hopefully it's fixed now.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102007 run on x86_64-linux 1

1 package built:
  • numix-cursor-theme

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102007 run on x86_64-darwin 1

1 package built:
  • numix-cursor-theme

@romildo
Copy link
Contributor

romildo commented Nov 3, 2020

LGTM.

@romildo romildo merged commit 4dc4b62 into NixOS:master Nov 3, 2020
@stephaneyfx
Copy link
Contributor Author

Thank you!

@stephaneyfx stephaneyfx mentioned this pull request Nov 6, 2020
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stephaneyfx @SuperSandro2000 @romildo @Janik-Haag