Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffmpeg-full: patch for libsrt deprecated API #101994

Merged
merged 1 commit into from Oct 29, 2020
Merged

ffmpeg-full: patch for libsrt deprecated API #101994

merged 1 commit into from Oct 29, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

ffmpeg uses functionality which has been removed from libsrt. This makes
things build again by taking a commit from master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member Author

Related to #101906.

@ofborg ofborg bot requested a review from codyopel October 29, 2020 05:52
@beardhatcode beardhatcode mentioned this pull request Oct 29, 2020
Closed
@beardhatcode
Copy link
Contributor

beardhatcode commented Oct 29, 2020 •
edited

This PR adds the patch suggested in https://trac.ffmpeg.org/ticket/8760

@peterhoeg
Copy link
Member Author

Fixes #101966

@peterhoeg peterhoeg merged commit 0cc9ad7 into NixOS:master Oct 29, 2020
@peterhoeg peterhoeg deleted the f/ffmpeg-full branch October 29, 2020 09:06
@jonringer
Copy link
Contributor

20.09 isn't affected by this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyopel codyopel Awaiting requested review from codyopel

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @beardhatcode @jonringer