mediatomb/gerbera: Add release note information for 21.03 #100348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/marvin opt-in |
|
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
|
Updated and fixed the conflict |
|
@ardumont please resolve the merge conflict. |
Note that it made into 2 entries, one about new options in the first section. Another in the breaking compatibility section due to the openFirewall option which changes the behavior.
Btw, I've rebased and fixed the conflict again (I did also last time you asked...). (It was also initially from another PR and it got split... The actual code describing Thanks for your time and consideration. Cheers, |
|
This obviously still needs to go into 21.05, because the changes are already merged but the release note is not. Somehow the manual is failing to build, can you check and resolve this @ardumont? /cc @jonringer |
|
@ardumont Did you see that unfortunately the NixOS tests for mediatomb are failing because of gerbera, while mediatomb still succeeds? First, the With gerbera understandibly being the new default, this is pretty bad. |
10 tasks
schmittlauch
suggested changes
May 28, 2021
| @@ -707,6 +725,28 @@ environment.systemPackages = [ | |||
| All services should use <xref linkend="opt-systemd.services._name_.startLimitIntervalSec" /> or <literal>StartLimitIntervalSec</literal> in <xref linkend="opt-systemd.services._name_.unitConfig" /> instead. | |||
| </para> | |||
| </listitem> | |||
| <listItem> | |||
There was a problem hiding this comment.
Suggested change
| <listItem> | |
| <listitem> |
| { path = "/var/lib/mediatomb/audio"; recursive = true; hidden-files = false; } | ||
| ]; | ||
| </programlisting> | ||
| </listItem> |
There was a problem hiding this comment.
Suggested change
| </listItem> | |
| </listitem> |
| @@ -707,6 +725,28 @@ environment.systemPackages = [ | |||
| All services should use <xref linkend="opt-systemd.services._name_.startLimitIntervalSec" /> or <literal>StartLimitIntervalSec</literal> in <xref linkend="opt-systemd.services._name_.unitConfig" /> instead. | |||
| </para> | |||
| </listitem> | |||
| <listItem> | |||
| <para> | |||
| The <link linked="opt-services.mediatomb">mediatomb service</link> | |||
There was a problem hiding this comment.
Suggested change
| The <link linked="opt-services.mediatomb">mediatomb service</link> | |
| The <literal>mediatomb</literal> service |
| @@ -242,6 +242,24 @@ | |||
| <literal>/var/lib/powerdns</literal> to <literal>/run/pdns</literal>. | |||
| </para> | |||
| </listitem> | |||
| <listitem> | |||
| <para> | |||
| The <link linked="opt-services.mediatomb">mediatomb service</link> is | |||
There was a problem hiding this comment.
Suggested change
| The <link linked="opt-services.mediatomb">mediatomb service</link> is | |
| The <literal>mediatomb</literal> service is |
There was a problem hiding this comment.
opt-services.mediatomb is no reference target, only its sub-options are.
| <programlisting> | ||
| services.mediatomb.package = pkgs.mediatomb; | ||
| </programlisting> | ||
| One new option <literal>openFirewall<literal> has been introduced which |
There was a problem hiding this comment.
Suggested change
| One new option <literal>openFirewall<literal> has been introduced which | |
| One new option <literal>openFirewall</literal> has been introduced which |
| { path = "/var/lib/mediatomb/pictures"; recursive = false; hidden-files = false; } | ||
| { path = "/var/lib/mediatomb/audio"; recursive = true; hidden-files = false; } | ||
| ]; | ||
| </programlisting> |
There was a problem hiding this comment.
Suggested change
| </programlisting> | |
| </programlisting> | |
| </para> |
This was referenced May 28, 2021
|
superseded by #124768 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the documentation [1] does not complain about anything
[1] https://nixos.org/manual/nixpkgs/stable/#chap-contributing
Related to #93450#issuecomment-706962271