Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.20.1 -> 1.21.0 #100346

Merged
merged 1 commit into from Oct 13, 2020
Merged

matrix-synapse: 1.20.1 -> 1.21.0 #100346

merged 1 commit into from Oct 13, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 12, 2020

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/v1.21.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 12, 2020
@ofborg ofborg bot requested a review from pacien October 12, 2020 16:52
@Ma27 Ma27 merged commit 546eb60 into NixOS:master Oct 13, 2020
@Ma27 Ma27 deleted the bump-matrix-synapse branch October 13, 2020 14:47
@Ma27
Copy link
Member Author

Ma27 commented Oct 13, 2020

I decided to skip 1.21.1 for now as it only fixes an issue with Debian packages.

Ported to 20.09 as c7c4e67 (also had to backport 9fbace9 as it was necessary to get matrix-synapse to build). @Ekleog @fadenb do you think we should also push this to 20.03?

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 13, 2020
@fadenb
Copy link
Contributor

fadenb commented Oct 13, 2020

The list of bugfixes is quite long and I assume quite a few people that use synapse are still on 20.03 (including myself ;) ).
If it is not much effort let's do it otherwise no security fixes included that "force" us to do it.

@Ma27
Copy link
Member Author

Ma27 commented Oct 13, 2020

Ported to 20.03 as 8e5088c, 3a10a00.

@ajs124
Copy link
Member

ajs124 commented Oct 15, 2020

otherwise no security fixes included that "force" us to do it

So much for that: https://github.com/matrix-org/synapse/releases/tag/v1.21.2
"This fix was originally included in v1.21.0 but was missing a security advisory"

Good that you backported it anyways @Ma27

@Ma27
Copy link
Member Author

Ma27 commented Oct 15, 2020

Heh yeah seen it :)
Currently building the new package, will file a PR for the two new bugfixes of 1.21.2 today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekleog Ekleog Ekleog approved these changes

@fadenb fadenb fadenb approved these changes

@Ralith Ralith Awaiting requested review from Ralith

@mguentner mguentner Awaiting requested review from mguentner

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@pacien pacien Awaiting requested review from pacien

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @fadenb @ajs124 @Ekleog