Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wayst: init at 2020-10-12 #100374

Merged
merged 1 commit into from Oct 21, 2020
Merged

wayst: init at 2020-10-12 #100374

merged 1 commit into from Oct 21, 2020

Conversation

berbiche
Copy link
Member

Motivation for this change

Package wayst, a simple terminal emulator that supports both Wayland and X11.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@berbiche

This comment has been minimized.

Sign in to view
@marvin-mk2 marvin-mk2 bot added the marvin label Oct 13, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 13, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@berbiche

This comment has been minimized.

Sign in to view
justinlovinger
justinlovinger approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@justinlovinger justinlovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Binary runs fine on my end.

@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 16, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@justinlovinger

This comment has been minimized.

Sign in to view
@marvin-mk2 marvin-mk2 bot requested a review from timokau October 17, 2020 03:29
timokau
timokau requested changes Oct 18, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nitpicks, and needs rebasing due to a merge conflict.

pkgs/applications/misc/wayst/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/wayst/default.nix Show resolved Hide resolved
@berbiche berbiche requested a review from timokau October 20, 2020 23:30
timokau
timokau approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timokau timokau merged commit ea0abe9 into NixOS:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinlovinger justinlovinger justinlovinger approved these changes

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@berbiche @justinlovinger @timokau